-
-
Notifications
You must be signed in to change notification settings - Fork 35.3k
Making base64 cctest deterministic makes it fail #13636
Copy link
Copy link
Closed
Labels
bufferIssues and PRs related to the buffer subsystem.Issues and PRs related to the buffer subsystem.c++Issues and PRs that require attention from people who are familiar with C++.Issues and PRs that require attention from people who are familiar with C++.lib / srcIssues and PRs related to general changes in the lib or src directory.Issues and PRs related to general changes in the lib or src directory.testIssues and PRs related to the tests.Issues and PRs related to the tests.
Metadata
Metadata
Assignees
Labels
bufferIssues and PRs related to the buffer subsystem.Issues and PRs related to the buffer subsystem.c++Issues and PRs that require attention from people who are familiar with C++.Issues and PRs that require attention from people who are familiar with C++.lib / srcIssues and PRs related to general changes in the lib or src directory.Issues and PRs related to general changes in the lib or src directory.testIssues and PRs related to the tests.Issues and PRs related to the tests.
The following patch makes the
base64cctest fail for me:That shouldn’t be happening, because
buffermight be 0-initialized anyway. Without this patch, valgrind complains that we use uninitialized parts ofbuffer(rightfully so, I assume).I don’t have the time to look into this right now, but I assume either the test is just asserting the wrong values, or something’s off with our base64 decoder implementation.
/cc @aqrln @seishun