Repository navigation
Collaborator nominations #12646
Description
Time to open another round of collaborator nominations.
-
- Most notable PR: module: add support for abi stable module API module: add support for abi stable module API #11975
- Other NodeCore PRs: https://github.com/nodejs/node/pulls?utf8=%E2%9C%93&q=is%3Apr%20author%3Ajasongin
- Helped review/contributed to trace controller PR Trace event support for Node.js #9304
- Creator and lead maintainer of cross-platform nvm like node version manager called Node Version Switcher (aka: nvs). Additional benefits of nvs include first class Windows support and support for Node-ChakraCore
- Member of Node Version management WG : https://github.com/nodejs/version-management
- https://github.com/nodejs/node/pulls/jasongin
- https://github.com/nodejs/node/commits/master?author=jasongin
- https://github.com/nodejs/abi-stable-node/commits/api-prototype-8.x?author=jasongin
- https://github.com/nodejs/node-api/commits/master?author=jasongin
-
- Most notable PR: Enable Node.js to run with Microsoft's ChakraCore engine Enable Node.js to run with Microsoft's ChakraCore engine #4765
- Other NodeCore PRs: https://github.com/nodejs/node/pulls?utf8=%E2%9C%93&q=is%3Apr%20author%3Akunalspathak
- Member of Build WG Add Kunal Pathak to Build WG build#649
- Added Win2016 support for Node CI libuv Windows CI: Windows server 2016 libuv/libuv#1245
- https://github.com/nodejs/node/pulls/kunalspathak
- https://github.com/nodejs/node/commits/master?author=kunalspathak
- https://github.com/nodejs/node-chakracore/commits/chakracore-master?author=kunalspathak
Activity
joshgav commentedon Apr 25, 2017
+1, Jason's work on N-API and Kunal's work on Windows and VS support in Node's build system have been really helpful contributions!
@jasnell: Fixed a couple links in the original post.
mikeal commentedon Apr 25, 2017
Are there people that were committers in N-API before it was merged that aren't committers in Core? Maybe we should do some kind of bulk issue for all of them because it should be uncontroversial given the impact of that work.
aruneshchandra commentedon Apr 25, 2017
@mikeal yes they are listed on the PR #11975
mhdawson commentedon Apr 25, 2017
+1 from me on the 2 nominations.
addaleax commentedon Apr 30, 2017
I’d like to nominate:
targos commentedon May 7, 2017
+1 to all 3 nominations.
mhdawson commentedon May 17, 2017
I'd like to add
@gireeshpunathil
Pull requests: https://github.com/nodejs/node/pulls/gireeshpunathil
Issues commented on: https://github.com/issues?utf8=✓&q=repo%3Anodejs%2Fnode+is%3Aissue+commenter%3Agireeshpunathil
mhdawson commentedon May 17, 2017
And +1 to all 4 nominations from me.
gibfahn commentedon May 17, 2017
+1 (to all 4)
sam-github commentedon May 17, 2017
+1 to all of them
evanlucas commentedon May 17, 2017
+1 to all 4
richardlau commentedon May 19, 2017
+1 to all 4 too
Fishrock123 commentedon May 24, 2017
@jasongin and @kunalspathak were added via #13200 (👏!)
Trott commentedon Jun 23, 2017
I think the only person remaining to be onboarded in this issue is @gireeshpunathil. I'll send them an email and try to set something up.
29 remaining items
Trott commentedon Oct 9, 2017
Both bmeurer and kfarnung are now Collaborators. 🎉
Now to schedule something with @apapirovski!
apapirovski commentedon Oct 9, 2017
@Trott email is in my profile. I'm generally pretty available and flexible. No rush :)
fhinkel commentedon Oct 15, 2017
I would like to nominate @hashseed because of his V8 expertise. Here are his commits.
hashseed commentedon Oct 15, 2017
Thanks for the nomination. I'd be honored to become a collaborator!
targos commentedon Oct 29, 2017
I would like to nominate @guybedford. He has been extremely helpful with the implementation and maintenance of ESM.
Comments: https://github.com/nodejs/node/search?q=commenter%3Aguybedford&type=Issues&utf8=%E2%9C%93
Commits: https://github.com/nodejs/node/commits/master?author=guybedford
PRs: https://github.com/nodejs/node/pulls?utf8=%E2%9C%93&q=is%3Apr%20author%3Aguybedford
evanlucas commentedon Oct 29, 2017
+1 to @hashseed and @guybedford
mcollina commentedon Oct 29, 2017
👍 for both @hashseed and @guybedford.
mhdawson commentedon Nov 1, 2017
+1 to @hashseed and @guybedford
joyeecheung commentedon Nov 3, 2017
I would like to nominate @maclover7 (thought they was a collaborator until I noticed not, we will get onboard into the build WG together tomorrow)
Commits in core
Issues/PRs in core
Issues/PRs in build
cjihrig commentedon Nov 3, 2017
+1 to @hashseed @guybedford and @maclover7
mhdawson commentedon Nov 3, 2017
+1 to maclover7 as well.
maclover7 commentedon Nov 3, 2017
Thank you @joyeecheung -- I'd love to join the team :)
evanlucas commentedon Nov 13, 2017
+1 to @maclover7 too
Trott commentedon Nov 24, 2017
Everyone nominated in this issue has been onboarded! I'm closing this issue. It's always good to have more nominations, so if you've got someone to nominate, open a new issue! Thanks!