Repository navigation
Destructuring Assignment Parse Error - works in Chrome & Safari but not Node #11480
Description
- Version: v6.9.5
- Platform: Darwin Honor.local 16.4.0 Darwin Kernel Version 16.4.0: Thu Dec 22 22:53:21 PST 2016; root:xnu-3789.41.3~3/RELEASE_X86_64 x86_64
- Subsystem: parser
This source: a=b=1;((a + 1), {c} = b)
- Works in Chrome 56.0.2924.87
- Works in Safari 10.0.3 (12602.4.8)
- Fails to parse in Node
Quick command-line test:
echo "a=b=1;((a + 1), {c} = b)" | node
These slight variations DO work in node:
a=b=1;((a), {c} = b)a=b=1;((a + 1), ({c} = b))
Activity
shanebdavis commentedon Feb 21, 2017
It also works in: Babel 6.23.1
addaleax commentedon Feb 21, 2017
@shanebdavis Fwiw, it also works in Node 7.x, which means it was likely fixed during a V8 upgrade.
/cc @nodejs/v8
shanebdavis commentedon Feb 21, 2017
@addaleax Thanks! That makes sense. I was wondering why it worked in Chrome and not Node.
Is 6.x scheduled to get V8 updates?
addaleax commentedon Feb 21, 2017
Not regularly. I think the process for these cases is to look for which commit(s) in V8 fixed the problem, see if is feasible to apply them to the old V8 branch and then cherry-pick them back.
Fishrock123 commentedon Feb 21, 2017
Eh I suppose we can keep the label on it if backporting is at all viable.
targos commentedon Feb 21, 2017
I Identified v8/v8@dfb8d33 as the commit that fixes it using
git bisect.targos commentedon Feb 21, 2017
#11483
deps: backport dfb8d33 from V8 upstream
test: add regression test for V8 parse error
targos commentedon Mar 8, 2017
Fixed by d0e934f
deps: backport dfb8d33 from V8 upstream
test: add regression test for V8 parse error