Repository navigation
child_process: fork does not accept null or undefined args array #10819
Description
Activity
I think it would make more sense to throw a TypeError over seeing it as no-args? What does everyone else think?
The handling should be the same across the
child_processAPIs for when argv arrays are passednullorundefined. What doexecFile/spawn[Sync]()do in this case?@sam-github spawn and execFile uses a normalizeSpawnArguments function to parse arguments.
var spawn = exports.spawn = function(/*file, args, options*/) { var opts = normalizeSpawnArguments.apply(null, arguments); var options = opts.options; var child = new ChildProcess(); debug('spawn', opts.args, options); child.spawn({ file: opts.file, args: opts.args, cwd: options.cwd, windowsVerbatimArguments: !!options.windowsVerbatimArguments, detached: !!options.detached, envPairs: opts.envPairs, stdio: options.stdio, uid: options.uid, gid: options.gid });
where as fork does something different...or it's own thing entirely rather.
How those functions are implemented internally is their own business, how they behave should be consistent. spawn and exec didn't used to share implementation, and their behaviour was bafflingly inconsistent, the code sharing helps ensure they behave identically, as do the tests.
@sam-github Should this remain open?
Yes, it sounds like there is an inconsistency, but no one has looked into it yet.
this is addressed through #10866 and is a close candidate? I may be wrong.
I wasted a whole bunch of time figuring out why my child processes were crashing due to invalid debug options even when I was passing in a new inspect port to use. Turns on I was using null as my args argument assuming it would NOT ignore the third argument in the fork function. This is very odd behaviour and will cost more time. The function should process arguments on a case by case basis and not be dependent on prior arguments. Seeing as this behaviour is not mentioned in the documentation and using null / undefined as an argument should be perfectly acceptable then this behaviour needs to change.
Reacted by Gireesh Punathil#20882 is a work in progress to address the ambiguity. Feel free to review that PR and provide any inputs, thanks!
Reacted by Shobhit Chittora
Version: 8.0.0-pre
Platform: Linux jsully 4.8.0-040800-generic #201610022031 SMP Mon Oct 3 00:32:57 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
Subsystem: child_process
It appears as though fork assumes there are no options args when the arg array is null or undefined. This results in ignored parameters set in the options object.
More info here
I will update with further details once I dig into the code.
ref. #10793