Skip to content

doc: http response.getHeader() documentation partially incorrect #10803

Closed
Closed
doc: http response.getHeader() documentation partially incorrect#10803
Labels
docIssues and PRs related to Node.js documentation.good first issueIssues that are suitable for first-time contributors.httpIssues and PRs related to the http subsystem.

Description

@mscdex
mscdex
opened on Jan 14, 2017
  • Version: v4.x-master
  • Platform: n/a
  • Subsystem: doc

The http documentation incorrectly states that response.getHeader() "can only be called before headers get implicitly flushed," which is not true (AFAICT) and we explicitly even test for the ability to safely call response.getHeader() after the headers/response is written. I think this sentence can be removed entirely from the http documentation.

Activity

  1. mscdex
    added
    docIssues and PRs related to Node.js documentation.
    good first issueIssues that are suitable for first-time contributors.
    httpIssues and PRs related to the http subsystem.
    on Jan 14, 2017
  2. jasnell
    added a commit that references this issue on Jan 18, 2017

    doc: HTTP response getHeader doc fix

    90a2bb5
  3. italoacasas
    added 2 commits that reference this issue on Jan 18, 2017

    doc: HTTP response getHeader doc fix

    322d815
  4. italoacasas
    closed this as completedon Jan 19, 2017
  5. MylesBorins
    added 2 commits that reference this issue on Mar 8, 2017

    doc: HTTP response getHeader doc fix

    f6f3fa0

    doc: HTTP response getHeader doc fix

    5118e05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    docIssues and PRs related to Node.js documentation.good first issueIssues that are suitable for first-time contributors.httpIssues and PRs related to the http subsystem.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions