Repository navigation
Lost JUnit support for V8 tests #236
Description
We've been floating an old patch for some time (nodejs/node@d8b4a7e) but unfortunately it doesn't apply anymore since V8 did a big refactor of its test runner.
This breaks V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/4781/
Activity
targos commentedon Jul 20, 2022
@nodejs/python @nodejs/build
bnoordhuis commentedon Jul 20, 2022
It's possible to fix up the patch but it's arguably a better idea to just use the built-in
--json-test-resultsflag and transform the JSON file to JUnit, or teach Jenkins the JSON format (possibly harder, I don't know how much harder.)kvakil commentedon Jul 25, 2022
Here's a script which does the JSON -> JUnit conversion:
https://gist.github.com/kvakil/8ed172559f5bc3c8391ec34065682599
It seems to work on all the cases I tried locally (on Linux: passed,
timeout, and failed test cases). One weird thing is that the JSON output
doesn't include all the successful test cases, only the failing ones and
the slowest
slow_tests_cutoffones. Of course, you can setslow_tests_cutoffarbitrary high in order to get all the output, whichis what that script assumes:
bnoordhuis commentedon Jul 28, 2022
Seems like a good forward. Can I suggest you PR it to nodejs/node? I don't know how to hook it up to the CI but someone else no doubt does.
One style nit: the project's python style is two space indent, not four.
cclauss commentedon Jul 29, 2022
Would this make sense to add to https://github.com/nodejs/tap2junit ?
kvakil commentedon Jul 30, 2022
PR is now at nodejs/node#44049 (with your style nit addressed).
I'm not opposed to this. I can't find tap2unit anywhere in the nodejs repo with
git grep tap2junit. Is it just hanging out in the Jenkins job config somewhere?cclauss commentedon Jul 30, 2022
https://github.com/nodejs/tap2junit is a URL that you can click on.
build: convert V8 test JSON to JUnit XML
[hack] build: convert V8 test JSON to JUnit XML
[hack] build: convert V8 test JSON to JUnit XML
[hack] build: convert V8 test JSON to JUnit XML
[hack] build: convert V8 test JSON to JUnit XML
[hack] build: convert V8 test JSON to JUnit XML
[hack] build: convert V8 test JSON to JUnit XML
[hack] build: convert V8 test JSON to JUnit XML
[hack] build: convert V8 test JSON to JUnit XML
build: convert V8 test JSON to JUnit XML
build: convert V8 test JSON to JUnit XML