This repository was archived by the owner on Apr 22, 2023. It is now read-only.
Revert "doc: clarify fs.symlink and fs.symlinkSync parameters"#8936
Closed
piscisaureus wants to merge 1 commit intonodejs:v0.12from
Closed
Revert "doc: clarify fs.symlink and fs.symlinkSync parameters"#8936piscisaureus wants to merge 1 commit intonodejs:v0.12from
piscisaureus wants to merge 1 commit intonodejs:v0.12from
Conversation
The offending doc change clarified nothing, but put the arguments to fs.symlink() and fs.symlinkSync() in the wrong order. This reverts commit 8146f2e. BUG: nodejs#8920
piscisaureus
added a commit
to nodejs/node
that referenced
this pull request
Jan 27, 2015
The offending doc change clarified nothing, but put the arguments to fs.symlink() and fs.symlinkSync() in the wrong order. This reverts commit 8146f2e. BUG: nodejs/node-v0.x-archive#8920 PR: nodejs/node-v0.x-archive#8936
|
I think this won't help, In addition this PR would introduce a new inconsistency:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The offending doc change clarified nothing, but put the arguments to
fs.symlink() and fs.symlinkSync() in the wrong order.
This patch should be applied to v0.10 too.
See also #8920