Skip to content
This repository was archived by the owner on Apr 22, 2023. It is now read-only.

Add tls.start()#848

Closed
weaver wants to merge 1 commit into
nodejs:masterfrom
weaver:tls_start
Closed

Add tls.start()#848
weaver wants to merge 1 commit into
nodejs:masterfrom
weaver:tls_start

Conversation

@weaver

@weaver weaver commented Mar 29, 2011

Copy link
Copy Markdown

Here's the pull request for tls.start(); see mailing list thread here. Thanks!

@ry

ry commented Apr 11, 2011

Copy link
Copy Markdown

Hey Ben,
Do you have time to put together a test for this? Just something simple in the style of test/simple/test-https-connecting-to-http.js ?

@weaver

weaver commented Apr 12, 2011

Copy link
Copy Markdown
Author

Sure thing, I'll write something up.

@pquerna

pquerna commented Jul 4, 2011

Copy link
Copy Markdown

@weaver did you have a chance to make a test? Could you update the pull request? Thanks!

@weaver

weaver commented Jul 5, 2011

Copy link
Copy Markdown
Author

This slipped my mind, apologies! I'll update the pull request today.

@jamesonjlee

Copy link
Copy Markdown

is there a chance this could get expanded to tls.createSocket(options) on which you can later call connect(port, host, callback)?

@koichik

koichik commented Jan 21, 2012

Copy link
Copy Markdown

Sorry for the delay, this has been fixed in v0.7.0 (#2489). You can pass socket: mySocket to tls.connect().
Closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants