This repository was archived by the owner on Apr 22, 2023. It is now read-only.
Repository navigation
Conversation
Try embedding the ` ... ^` lines inside the `SyntaxError` (or any other native error) object before giving up and printing them to the stderr. fix nodejs#6920 fix nodejs#1310
|
Thank you for contributing this pull request! Here are a few pointers to make sure your submission will be considered for inclusion. The following commiters were not found in the CLA:
You can fix all these things without opening another issue. Please see CONTRIBUTING.md for more information |
Member
Author
|
Not sure if there any point in backporting it to v0.10, seems to be mostly a matter of style. |
Member
Author
There was a problem hiding this comment.
This is because error was appended to the exception without \n as a first char, I think that generally it is a better approach.
|
Just a couple comments, but overall LGTM. |
Member
Author
|
Thank you, landed in f1de13b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try embedding the
... ^lines inside theSyntaxError(or any othernative error) object before giving up and printing them to the stderr.
fix #6920
fix #1310