[shanksauce]

When using express-ws, I've noticed a TypeError is thrown in early terminating router middleware. Here is code to reproduce the error:

var app = require('express')();
var expressWs = require('express-ws')(app);

// Terminating middleware
app.use('/ws', function(req, res, next) {
  try {
    return res.status(500).end();
  } catch(ex) {
    console.log(ex.name, ex.message);
  }
});

app.ws('/ws', function(ws, req) { });

app.listen(8888);

Package versions:

express: 4.13.1
express-ws: 0.2.6

[Fishrock123]

Looks like a bug, bookmarking in case it does not get noticed. @Fishrock123

[thefourtheye]

FWIW, io.js 2.3.4 and node 0.12.7 doesn't have this problem. Still, we need to fix this. 👍

[jasnell]

@Fishrock123 ... did you ever have a chance to look at this?

[Fishrock123]

@jasnell No I haven't.

[thefourtheye]

@jasnell this fix landed in io.js already

[jasnell]

@thefourtheye .. ok, I'll queue it up to land in v0.12 as well. thanks!