Skip to content

Update tinyglobby dependency for v12#3322

Open
hlovdal wants to merge 1 commit into
nodejs:mainfrom
hlovdal:v12-deps
Open

Update tinyglobby dependency for v12#3322
hlovdal wants to merge 1 commit into
nodejs:mainfrom
hlovdal:v12-deps

Conversation

@hlovdal
Copy link
Copy Markdown

@hlovdal hlovdal commented Jun 1, 2026

Checklist
  • npm install && npm run lint && npm test passes
  • commit message follows commit guidelines
Description of change

It was suggested to apply this dependency update on the main branch first, so here is a pull request.

Basically updating tinyglobby to the given version transitively solves a couple of security issues with its dependencies. More details in the original pull request.

(cherry picked from commit 53efeb2)
@cclauss
Copy link
Copy Markdown
Contributor

cclauss commented Jun 2, 2026

Rerunning five failing tests that are all on Node.js 26:

  1. Tests / ubuntu-24.04-arm - 3.14 - 26.x (pull_request) (fixed on retest)
  2. Tests / windows-11-arm - 3.14 - 26.x (pull_request)
  3. Tests / windows-latest - 3.10 - 26.x (pull_request)
  4. Tests / windows-latest - 3.12 - 26.x (pull_request)
  5. Tests / windows-latest - 3.14 - 26.x (pull_request)

@hlovdal
Copy link
Copy Markdown
Author

hlovdal commented Jun 4, 2026

The windows + nodejs 26 build failure is a generic issue. I enabled worflows in my fork, and with plain main + one commit to trigger action on my test branch, it fails there as well.

I backported the commits to add nodejs 26 support to a branch based on the last v11 release, and it also fails in the same way there.

I then did the same for V10, but then all windows builds fail so I am missing something additional. I might try to attempt to resolve that attempt, but probably not (the hope was that if I want back in history I would find a commit where nodejs 26 did not fail, and then I could bisect from there).

So conclusion is that these build failures are not related to the tinyglobby update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants