Repository navigation
git-node: refuse to run without configurations/on wrong revs - #200
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #200 +/- ##
=======================================
Coverage 93.73% 93.73%
=======================================
Files 17 17
Lines 654 654
=======================================
Hits 613 613
Misses 41 41Continue to review full report at Codecov.
|
bmeck
approved these changes
Mar 5, 2018
bmeck
left a comment
Member
There was a problem hiding this comment.
would have been less confusing to me since I use default OSX git which I tend to land off git checkout upstream/master which this would show as detached head instead of confusion.
Member
|
Maybe add a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It now refuses to run if
Refs: nodejs/node#18914
Fixes: #198