Skip to content

git-node: refuse to run without configurations/on wrong revs - #200

Merged
joyeecheung merged 1 commit into
nodejs:masterfrom
joyeecheung:refuse-on-pr-branch
Mar 5, 2018
Merged

joyeecheung merged 1 commit into
nodejs:masterfrom
joyeecheung:refuse-on-pr-branch

Conversation

@joyeecheung

@joyeecheung joyeecheung commented Mar 5, 2018 •

Copy link
Copy Markdown
Member

It now refuses to run if

  1. User has not configured upstream or branch - no more defaults.
  2. User is not on the branch configured
  3. User is on detached HEAD

Refs: nodejs/node#18914
Fixes: #198

@codecov

codecov Bot commented Mar 5, 2018 •

Copy link
Copy Markdown

Codecov Report

Merging #200 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #200   +/-   ##
=======================================
  Coverage   93.73%   93.73%           
=======================================
  Files          17       17           
  Lines         654      654           
=======================================
  Hits          613      613           
  Misses         41       41

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a992a24...b8c1591. Read the comment docs.

@bmeck bmeck left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would have been less confusing to me since I use default OSX git which I tend to land off git checkout upstream/master which this would show as detached head instead of confusion.

@bmeck bmeck mentioned this pull request Mar 5, 2018
@gibfahn

gibfahn commented Mar 5, 2018

Copy link
Copy Markdown
Member

Maybe add a Fixes: https://github.com/nodejs/node-core-utils/issues/198

@joyeecheung
joyeecheung merged commit 7a274ab into nodejs:master Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants