Skip to content

support v8 revert #504

Open
Open

Description

@gengjiawen

support revert v8 commit by hash, should be usefully when test V8 function. Like nodejs/node#35415 (comment), I have a guess, but cumbersome reverting the commit in node.js repo.

Activity

  1. joyeecheung commented on Oct 20, 2020

    @joyeecheung
    Member

    Would be useful for nodejs/node-v8#175 too. We probably just need to add --reverse to the git apply command to make it work

  2. gengjiawen commented on Oct 20, 2020

    @gengjiawen
    MemberAuthor

    Also my guess for nodejs/node#35415 (comment) is right, though I manually revert them, take quite some time (The final fix is not revert though, I found a workaround).

  3. github-actions commented on Jan 19, 2021

    @github-actions
    Contributor

    This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

  4. gengjiawen commented on Jan 19, 2021

    @gengjiawen
    MemberAuthor

    not stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions