Skip to content

FR: check CI job result聽#308

Closed
Closed
FR: check CI job result#308
Labels
feature requestNew features for node-core-utilsgit-nodepr-checkerIssues related to pr checker

Description

@refack
refack
opened on Nov 16, 2018

I was about to suggest that if the PR is labeled V8 Engine we should check for a V8 CI job, but I just saw that we already do 馃槃 :

i  Last V8 CI on 2018-11-10T22:17:13Z: https://ci.nodejs.org/job/node-test-commit-v8-linux/1838/
i  Last Lite PR Pipeline CI on 2018-11-14T17:57:34Z: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1615/

So how about we query Jenkins for it's status?

Activity

  1. refack
    added
    feature requestNew features for node-core-utils
    git-node
    pr-checkerIssues related to pr checker
    on Nov 16, 2018

  2. joyeecheung commented on Nov 17, 2018

    @joyeecheung
    joyeecheung
    on Nov 17, 2018
    Member

    So..the code for querying Jenkins and parsing the results are already part of ncu-ci, I guess we just need some glue to invoke them from git-node..

    But I am not 100% sure since our CI is still not yet in a false-positive-free state

  3. refack commented on Nov 17, 2018

    @refack
    refack
    on Nov 17, 2018
    ContributorAuthor

    I'll try to draft something this weekend.

  4. mmarchini commented on Aug 12, 2020

    @mmarchini
    mmarchini
    on Aug 12, 2020
    Contributor

    Implemented on #422

  5. mmarchini
    closed this as completedon Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    feature requestNew features for node-core-utilsgit-nodepr-checkerIssues related to pr checker

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions