This repository was archived by the owner on Oct 15, 2020. It is now read-only.
chakrashim: use microtask queue to run Promise#45
Merged
Conversation
Author
|
@nodejs/chakracore Please review. This fixed a module compatibility issue reported by @munyirik. |
Contributor
|
Looks good to me |
Previously we enqueue Promise callbacks with "process.nextTick". This turns out incompatible with node/v8 and causing execution order differences, breaking some Promise uses. This change implements a micro task queue in each ContextShim and uses it to run Promise callbacks (read: nodejs/node-v0.x-archive#8325). PR-URL: nodejs#45 Reviewed-By: Sandeep Agarwal <Agarwal.Sandeep@microsoft.com>
Author
|
Thanks @agarwal-sandeep! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we enqueue Promise callbacks with "process.nextTick". This
turns out incompatible with node/v8 and causing execution order
differences, breaking some Promise uses.
This change implements a micro task queue in each ContextShim and uses it
to run Promise callbacks
(read: nodejs/node-v0.x-archive#8325).