Do we need wrapper_? #140

Activity

1. gabrielschulhof commented on Jun 10, 2020

   

   gabrielschulhof

   on Jun 10, 2020

   ContributorAuthor

   More actions

   This is the extent to which we use wrapper_ and env_:

   node-addon-examples/6_object_wrap/napi/myobject.cc

   Lines 6 to 11 in dc86a66

   	MyObject::MyObject(double value)
   	: value_(value), env_(nullptr), wrapper_(nullptr) {}
   	MyObject::~MyObject() {
   	napi_delete_reference(env_, wrapper_);
   	}

   and

   node-addon-examples/6_object_wrap/napi/myobject.cc

   Lines 72 to 78 in dc86a66

   	obj->env_ = env;
   	status = napi_wrap(env,
   	jsthis,
   	reinterpret_cast<void*>(obj),
   	MyObject::Destructor,
   	nullptr, // finalize_hint
   	&obj->wrapper_);
2. gabrielschulhof commented on Jun 15, 2020

   

   gabrielschulhof

   on Jun 15, 2020

   ContributorAuthor

   More actions

   Compare with the Nan implementation. The use of the persistent reference may stem from there. If so, it may be a good time to diverge, especially since we document that we discourage storing the napi_env.
3. gabrielschulhof commented on Jun 16, 2020

   

   gabrielschulhof

   on Jun 16, 2020

   ContributorAuthor

   More actions

   In fact, none of the Nan examples store a persistent reference to the JS instance. We should remove it.

   👍React with 👍1Reacted by Michael Dawson
4. gabrielschulhof

   added a commit that references this issue on Aug 5, 2020

   remove wrapper_ from napi_wrap examples

   ...

   16112d3