Skip to content

warning when building example #122

Description

@calvinmetcalf

when building example 6 with nan I get

  CXX(target) Release/obj.target/addon/myobject.o
../myobject.cc:24:3: warning: ignoring return value of function declared with 'warn_unused_result' attribute [-Wunused-result]
  exports->Set(context,
  ^~~~~~~~~~~~ ~~~~~~~~
1 warning generated.

Activity

  1. helio-frota commented on Nov 20, 2020

    @helio-frota
    Contributor

    hi @calvinmetcalf thanks for report this. but I can't see this warning anymore (tested with node v12.19.1).

    make: Entering directory '/home/hf/code/napi/node-addon-examples/6_object_wrap/node-addon-api/build'
      CXX(target) Release/obj.target/addon/addon.o
      CXX(target) Release/obj.target/addon/myobject.o
      SOLINK_MODULE(target) Release/obj.target/addon.node
      COPY Release/addon.node
    make: Leaving directory '/home/hf/code/napi/node-addon-examples/6_object_wrap/node-addon-api/build'
    audited 2 packages in 3.122s
    found 0 vulnerabilities
    
    $ node --version
    v12.19.1
    

    Should this issue be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions