test: Add tests for ThreadSafeFunction's NonBlock function overloads#1249
Merged
JckXia merged 2 commits intonodejs:mainfrom Jan 24, 2023
Merged
test: Add tests for ThreadSafeFunction's NonBlock function overloads#1249JckXia merged 2 commits intonodejs:mainfrom
JckXia merged 2 commits intonodejs:mainfrom
Conversation
JckXia
force-pushed
the
add-tests-for-threadsafe-non-block
branch
from
544a266 to
79ccf60
Compare
Contributor
Member
|
@KevinEady I see you ran a number of tests. Looks like they passed, are you good with this landing? |
Member
Author
|
Landed as 78b5a15 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added test coverage for
ThreadSafeFunction's missingNonBlockingCallfunction overloads. In particular test cases for when we pass just the singlejsfunction into the tsfn, or nothing at all.