test: Add test cased for failed task cancellations#1214
Merged
JckXia merged 2 commits intonodejs:mainfrom Oct 13, 2022
Merged
Conversation
legendecas
reviewed
Oct 11, 2022
test/async_worker.cc
Outdated
| std::string echo; | ||
| }; | ||
|
|
||
| std::condition_variable cv; |
Member
There was a problem hiding this comment.
Might be worth moving these variables to be members of FailCancelWorker instead.
Member
Author
There was a problem hiding this comment.
Yep I agree. Made new changes
legendecas
approved these changes
Oct 13, 2022
Member
Author
|
Landed as 257a52f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow up to #1202 (comment). Adding a test for checking when a task cancellation is unsuccessful (task is already queued and executing).