test: Add test coverage to TSFN::New() overloads#1201
Merged
legendecas merged 4 commits intonodejs:mainfrom Nov 15, 2022
Merged
test: Add test coverage to TSFN::New() overloads#1201legendecas merged 4 commits intonodejs:mainfrom
legendecas merged 4 commits intonodejs:mainfrom
Conversation
Contributor
|
Hi @JckXia , I took a look at this and have a few questions:
|
Member
Author
|
Hey @KevinEady, For your first question, not at the moment. My plan was to complete coverage for For your second question, I think I may have missed them and have also made a mistake in the test coverage doc for Edit: I think |
legendecas
approved these changes
Nov 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding test coverage for
TSFN::Newoverloads where we provide the async resource name and/or the async resource object but no finalizer callbacks.