Repository navigation
Async handles and Errors #233
Description
Activity
Thanks for the test case, this will help investigate and come up with an solution.
Reacted by Brian CookeBelieve these are related: nodejs/node#15371
Made some progress on the plane today. Likely needs 2 PRs. One to fix up escaping of handles when the handle is undefined and then one to add napi_throw_fatal. Managed to get the test case to throw the expected error but still have work to validate what I have makes sense and then generate tests.
@fivdi thanks for the test case it was very helpful.
Reacted by Brian Cooke and Deepak RajamohanThis will add the function needed to get the exception to come out: nodejs/node#19337, but there is still another fix needed for the right exception to come out in this test case. I'll work on the PR for that.
- added a commit that references this issue
on Mar 18, 2018 PR to address escape issue that was preventing the right exception from coming out.
EDIT: Turns out this was incorrect, so ignore.
Once the 2 PRs above land we can look at the PR to add a method in node-addon-api to be able to through an exception and validate the test case in this issue passes.
Reacted by Nicola Del Gobbo and Deepak Rajamohan#245 along with the earlier PR (nodejs/node#19337).
Will let you get the correct exception if you use:
napi_fatal_exception(env, e.Value());Next step will be to add function to throw the fatal exception with node-addon-api itself along with a test.
There is no fixed time when it would be needed, but sooner than later would be better so that we have test coverage. You can writ it using napi_fatal_exception and then can change that to the node-add-api method when its available.
- added a commit that references this issue
on Aug 24, 2022 - added a commit that references this issue
on Aug 26, 2022
Async handles can be used to "wakeup" the event loop and get a callback called from another thread. However, if the callback throws an error it doesn't appear to be possible to handle the error and have it displayed to the user.
An example of such an async handle can be seen here. This async handle is initialized to call DispatchEvent when told to do so once per second. The callback is called by DispatchEvent. If the callback throws an error what needs to be done to display the error to the user?