Skip to content
This repository was archived by the owner on Sep 2, 2023. It is now read-only.
This repository was archived by the owner on Sep 2, 2023. It is now read-only.

JSON modules are being reverted on web #391

Closed

Description

@guybedford

See whatwg/html#4943, it appears this is due to lack of consensus between browsers based on a security concern. It does not seem to imply that they won't be implemented in future.

Given that we have erred on the side of web compatibility so far in the implementation, I would like to suggest we bring back the --experimental-json-modules flag for Node.js as we unflag modules to indicate the stability of the feature.

For example, were JSON modules to reland but with slightly different semantics (eg import json from './file.json' as json has been proposed or similar), then that keeps the door open for Node.js to be able to share in any new semantics.

Activity

  1. devsnek commented on Sep 28, 2019

    @devsnek
    Member

    we don't have the security problem that the web has, I see no reason to destabilise it.

  2. ljharb commented on Sep 28, 2019

    @ljharb
    SponsorMember

    I am also highly skeptical that any new syntax would gain consensus to indicate mime/module type.

  3. MylesBorins commented on Sep 30, 2019

    @MylesBorins
    Contributor

    I think that while stakeholders from the web discuss the feature and figure out if it has a future it is reasonable for us to include the flag, for now. While it is not the most convenient we can use makeRequire to synchronously parse JSON from disk

  4. Fishrock123 commented on Oct 7, 2019

    @Fishrock123
    Contributor

    As far as I am aware, there is no precedent for re-experimental-flagging a feature. That may be Semver-Major.

  5. hybrist commented on Oct 7, 2019

    @hybrist
    Contributor

    Does it change things that the unflagged feature is still behind --experimental-modules itself? E.g. it was never "fully" unflagged.

  6. MylesBorins commented on Oct 7, 2019

    @MylesBorins
    Contributor
  7. guybedford commented on Oct 9, 2019

    @guybedford
    ContributorAuthor

    The PR for Node.js core has been merged here. We can unflag or reconsider stability here at any time further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    modules-agendaTo be discussed in a meeting

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions