llnode.cc: Combine array-length and string-length arguments#124
Merged
hhellyer merged 1 commit intonodejs:masterfrom Aug 22, 2017
Merged
llnode.cc: Combine array-length and string-length arguments#124hhellyer merged 1 commit intonodejs:masterfrom
hhellyer merged 1 commit intonodejs:masterfrom
Conversation
Merge the string and array length arguments into one option as they can never both apply at the same time. Support a short option (-l) to the the user quickly specify how many elements of either strings or arrays to display.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I reviewed PR #116 for @joyeecheung I noticed that we have separate length arguments to v8 inspect for Strings and Arrays when we can only be inspecting one or the other. This PR merges the two into
--lengthas they can never both apply at the same time. It also supports a short option,-l, to the user quickly specify how many elements of either strings or arrays to display. The major usability improvement is that you can just specify-linstead of having to type out--array-lengthor--string-length.I did consider using
--countand-cinstead and I'm happy to swap around if anyone thinks that's better.