Repository navigation
Upcoming metadata changes in V8 7.7 #287
Description
Activity
Interesting, the type of those fields didn't change, but they are all prefixed by
__int. Is the metadata generated for Torque classes prefixed by the the metadata type instead of the field type? That's probably not a good idea, if a field type changes it wouldn't reflect on the metadata name, and we wouldn't have a way to check the type on llnode...class_Symbol__name__Objectwas removed as well, I'm guessing in this version. Still investigating.So I renamed the String metadata back to their previous names in: https://chromium-review.googlesource.com/c/v8/v8/+/1847783. I also added the missing metadata for symbols. Will update the tests once this is merged to core.
If the above gets merged, no changes will be necessary on llnode for 7.7 (and then we can close this issue). I already have patches to fix 7.2, 7.4 and 7.6 (I haven't opened PRs with all of them yet because some are blocked by #303), so once the metadata lands upstream and is backported to core, we'll have llnode working on Node.js v12 :)
- added a commit that references this issue
on Jan 8, 2020 - added a commit that references this issue
on Jan 14, 2020 - added a commit that references this issue
on Feb 6, 2020 There used to be a test in core that verified the existence of the metadata used by llnode. However, that test was removed in nodejs/node@9a0aaa6. After that, I think @mmarchini had her own way of detecting the breaking changes. You'll definitely want some automated way to detect the breaking changes because they happen frequently with V8 updates.
The V8 7.7 update requires the following adjustments to the postmortem debugging metadata constants:
v8dbg_class_ConsString__first__String
v8dbg_class_ConsString__second__String
v8dbg_class_SlicedString__offset__SMI
v8dbg_class_ThinString__actual__String
Refs: nodejs/node#28918