Repository navigation
avoid using Buffer constructor - #206
Merged
phillipj merged 1 commit intoJan 11, 2019
Merged
Conversation
addaleax
approved these changes
Nov 24, 2018
phillipj
approved these changes
Nov 24, 2018
maclover7
reviewed
Nov 24, 2018
| function triggerBuild (options, cb) { | ||
| const { repo } = options | ||
| const base64Credentials = new Buffer(jenkinsApiCredentials).toString('base64') | ||
| const base64Credentials = Buffer.from(jenkinsApiCredentials, 'base64') |
Contributor
There was a problem hiding this comment.
Wouldn't toString() still need to be called?
This diff should make things ok, I believe:
Suggested change
| const base64Credentials = Buffer.from(jenkinsApiCredentials, 'base64') | |
| const base64Credentials = Buffer.from(jenkinsApiCredentials).toString('base64') |
phillipj
pushed a commit
that referenced
this pull request
Jan 15, 2019
The existing code assumes that the credentials are already in base64, but they are actually not. The code has to read the credentials in plain text and base 64 encode them. Ref: #206 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.