Skip to content

Replaced the new Travis token - #795

Closed
LaurentGoderre wants to merge 1 commit into
masterfrom
new-token
Closed

LaurentGoderre wants to merge 1 commit into
masterfrom
new-token

Conversation

@LaurentGoderre

Copy link
Copy Markdown
Member

No description provided.

@LaurentGoderre

Copy link
Copy Markdown
Member Author

@LaurentGoderre

Copy link
Copy Markdown
Member Author

@phillipj it doesn't seem to work. Did you encrypt it for this repo?

@phillipj

Copy link
Copy Markdown
Member

I was convinced so, yes..

$ cd into/repo/dir
$ travis encrypt -r nodejs/docker-node GITHUB_API_TOKEN="xyz"

Haven't encrypted secrets like these for Travis before though, so I wouldn't be surprised if I'm doing something wrong. Any thoughts?

@phillipj

Copy link
Copy Markdown
Member

Does it require me to have collaborator status in this repo?

@LaurentGoderre

Copy link
Copy Markdown
Member Author

@phillipj I personally prefer to have it here: https://travis-ci.com/nodejs/docker-node/settings

@LaurentGoderre

Copy link
Copy Markdown
Member Author

It's worth noting that if you add it, none of us will see it, the only way to change it is deleting it and re-adding it, which I think makes a lot of sense for security.

@phillipj

Copy link
Copy Markdown
Member

By looking at the repositories listed under "My repositories" on travis-ci.com, it might look like I have to be a collaborator to be able to change Travis CI settings on a repo. docker-node is currently not in that list, and I don't see an Settings-option under "More options" on travis-ci.com/nodejs/docker-node.

We can either test giving me temporary collaborator status here or we'd have to summon someone else, probably an org admin.

@LaurentGoderre are you able/want to do the former?

@LaurentGoderre

Copy link
Copy Markdown
Member Author

@phillipj try it now!

@phillipj

Copy link
Copy Markdown
Member

@LaurentGoderre thanks, that did the trick! GITHUB_API_TOKEN was already listed there, I'm assuming because of the .travis-ci.yml file.

I re-created it now, could you give it at try? If that also fails, I could even create a new token just to try everything..

@phillipj

Copy link
Copy Markdown
Member

I take it the environment variable I created on travis-ci.com worked, feel free to remove my collaborator status from this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants