Repository navigation
Update the baseimage to debian:stretch-slim for node:slim image #821
Description
Now security patches are limited to certain architectures for jessie release.
Refer following links for more information:
https://lists.debian.org/debian-security-announce/2018/msg00132.html
debuerreotype/docker-debian-artifacts#44 (comment)
vicamo/docker_buildpack-deps#33
Because of the above reason, we'll have to move to the next release of debian to build it on all different archs and works fine.
Activity
mkumatag commentedon Jul 19, 2018
I got a recommendation of adding
Dockerfiletemplate in root directory by @PeterDaveHello. But in this case, I need to change the content ofDockerfile-slim.templateto accommodate the changes needed for the stretch release.We have 2 ways of doing this:
Dockerfile-slim-stretch.templateand mantain the changes for stretch-slim releaseDockerfile-slim.templatefile which will enforce everyone to start using stretch as baseimage(one way it will make sure every damn image will work properly on all the arch)So I need @PeterDaveHello and your team's opinion here to make the changes.
mkumatag commentedon Jul 19, 2018
/cc @nodejs/docker
kbirger commentedon Aug 8, 2018
This would be wonderful. I have a requirement to be using Stretch for my base images for the security fixes, etc, and a requirement for slim to conserve space.
@mkumatag I would think Option 2 is better. Stretch is considered stable now.
Is there an eta on when this issue might be addressed?
mkumatag commentedon Aug 8, 2018
@kbirger I already have a working PR ready, I'm just waiting for nodejs team to merge it.
@PeterDaveHello @LaurentGoderre @chorrell
LaurentGoderre commentedon Sep 5, 2018
To minimize disruption I created an alternate PR that gives users the choice between jessie or stretch for the slim variant.
I don't think we should switch the
slimvariant without also changing the default variant.lag-linaro commentedon Nov 1, 2018
Is there an update on this please?
The Docker Official Images build for Node is currently broken on ARM64.
PeterDaveHello commentedon Nov 2, 2018
We've changed default & slim variant to Stretch in the base image, and applied to the latest v11 release, would migrate v6, v8 & v10 to Stretch in future.
PeterDaveHello commentedon Nov 2, 2018
@lag-linaro I think we have ARM64 builds for these tags:
Tags: 8.12.0-alpine, 8.12-alpine, 8-alpine, carbon-alpine
Tags: 8.12.0-stretch, 8.12-stretch, 8-stretch, carbon-stretch
Tags: 6.14.4-stretch, 6.14-stretch, 6-stretch, boron-stretch
Tags: 11.0.0-alpine, 11.0-alpine, 11-alpine, alpine
Tags: 11.0.0-slim, 11.0-slim, 11-slim, slim
Tags: 11.0.0-stretch, 11.0-stretch, 11-stretch, stretch, 11.0.0, 11.0, 11, latest
Tags: 10.13.0-alpine, 10.13-alpine, 10-alpine, dubnium-alpine
Tags: 10.13.0-stretch, 10.13-stretch, 10-stretch, dubnium-stretch
Ref: https://github.com/docker-library/official-images/blob/master/library/node
lag-linaro commentedon Nov 2, 2018
@PeterDaveHello the trouble is, we have a dependency for Ghost:
https://github.com/docker-library/ghost/blob/master/2/debian/Dockerfile
Will the default 8-slim repo be moved to 8-stretch?
lag-linaro commentedon Nov 2, 2018
Another reference/request: TryGhost/docker-library-ghost#157 (comment)
It would be good if you could move all of your default images to Stretch.
Jessie is no longer receiving updates.
PeterDaveHello commentedon Nov 2, 2018
Jessie has LTS support until June 30, 2020, from the last discussion, we may transfer to Stretch about 1 month later.
cc @chorrell
chorrell commentedon Nov 2, 2018
Maybe we need a
slim-stretchvariant for 8.x.x and 10.x.x for the Ghost image to use?PeterDaveHello commentedon Nov 2, 2018
maybe
chorrell commentedon Nov 2, 2018
But...I’m not sure it’s worth the effort. I’d rather just switch the slim variant for the next v8.x.x release
PeterDaveHello commentedon Nov 2, 2018
maybe open an issue for more formal discussion?
kbirger commentedon Nov 2, 2018
I don't understand - has there been any movement on this issue or not?
PeterDaveHello commentedon Nov 7, 2018
No, we haven't made any decision yet.
PeterDaveHello commentedon Nov 7, 2018
Ping @nodejs/docker for suggestions ;)
chorrell commentedon Nov 7, 2018
I think at this point we should just start switching over to stretch when we update each v10 and v8 image. The required changes are already in the repo. I think we can proabbly skip v6 since it will be gone soon and I don't see it being updated in the near future (but I could be wrong).
This would technically be a breaking change, but given the current situation, things are broken already. In the future we should create
stretch-slimvariant to set the groundwork for the next Debian release.LaurentGoderre commentedon Nov 7, 2018
That's what I tried to do with #850
chorrell commentedon Nov 7, 2018
Can we revisit the approach in #850 with what we have now?
LaurentGoderre commentedon Nov 8, 2018
Absolutely. I am very busy until end of week but I should have more time to dedicate to this next week.
LaurentGoderre commentedon Nov 16, 2018
@chorrell I updated my PR #850
LaurentGoderre commentedon Nov 16, 2018
Something is wrong with the build. It can't fetch any of the keys
tianon commentedon Nov 16, 2018
See https://bugs.debian.org/913614 and the linked PRs/commits on docker-library/busybox#55.
chorrell commentedon Nov 16, 2018
--> #912
chorrell commentedon Dec 4, 2018
Closing as stretch is now the default, and we provide a
jessieandjessie-slimoptions for those who need it.