Repository navigation
How to join docker team? #444
Description
Activity
Could someone on the @nodejs/tsc add me or @chorrell as a team maintainer for the @nodejs/docker team. We still have members of that have not yet been added properly to the team.
@Starefossen I've made you a maintainer.
Reacted by Hans Kristian FlaattenSo is there any reference about how people can get involved?
And kinda related when this lands, is there any need to go through PRs for patch releases of node?
@cjihrig (Colin Ihrig)
@Starefossen I've made you a maintainer.Many thanks! Apparently I can not add team members which are outside of the organisation, would you mind hadding @SimenB to the org, or is there any other way he can join the org?
PeterDaveHello (Peter Dave Hello)
So is there any reference about how people can get involved?Yes, both GOVERNANCE.md and CONTRIBUTING.md should cover that.
SimenB (Simen Bekkhus)
I still haven't gotten access either, #414Apparently you need to be a member of the Node.js origination on GitHub before I can add you to the team.
SimenB (Simen Bekkhus)
And kinda related when this lands, is there any need to go through PRs for patch releases of node?No, the master branch for this repo is restricted from directly being pushed to without going through a PR (or technically it is the CI verification that is the restriction). However, I would like to propose a change that such PRs can be self merged directly without waiting for other team members review.
Accepted @PeterDaveHello and sent an invite to @SimenB
Reacted by Simen BekkhusThanks all.
@PeterDaveHello please also make a Pull Reguest to add yourself properly to the collaborators list in README!
@Starefossen sure thing! Thanks for reminding!
Done #445 🎉
Hi, I'm already a member of nodejs organization, and a contributor of
docker-nodeproject, I wonder how can I join this docker team? Thanks.