Skip to content
This repository was archived by the owner on Apr 18, 2018. It is now read-only.

doc: reorg and cleanup - #59

Merged
jasnell merged 5 commits into
masterfrom
refactor-lts
Apr 14, 2015
Merged

jasnell merged 5 commits into
masterfrom
refactor-lts

Conversation

@jasnell

@jasnell jasnell commented Apr 14, 2015

Copy link
Copy Markdown
Member

This is a significant update.

  • The document is restructured to have a more logical flow.
  • The LTS straw man is removed (it was just a straw man,
    after all, and it was causing confusion)
  • The supported platforms bit is simplified to better reflect
    reality.
  • Address breaking changes in the build
  • Clarify the release tagging and maintenance branching model

The idea here is to simplify, clarify and define a branching model that
is closer to reality. It's a significant change that will require
additional review.

The LTS straw man is removed entirely. It can be added back in as a
separate document later on if necessary.

This is a significant update.

* The document is restructured to have a more logical flow.
* The LTS straw man is removed (it was just a straw man,
   after all, and it was causing confusion)
* The supported platforms bit is simplified to better reflect
   reality.
* Address breaking changes in the build
* Clarify the release tagging and maintenance branching model

The idea here is to simplify, clarify and define a branching model that
is closer to reality. It's a significant change that will require
additional review.

The LTS straw man is removed entirely. It can be added back in as a
separate document later on if necessary.
This was referenced Apr 14, 2015
@jasnell

jasnell commented Apr 14, 2015

Copy link
Copy Markdown
Member Author

This PR would obsolete and replace #57 and #56

@jasnell

jasnell commented Apr 14, 2015

Copy link
Copy Markdown
Member Author

Comment thread README.md

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in both node.js and io.js

Sounds like there is two in both :)

@Fishrock123

Copy link
Copy Markdown
Contributor

I personally like a lot of this more. IMO the entire maintenance thing should be much easier for people to understand than the previous LTS stuff.

Comment thread README.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean that patch level releases wouldn't be tagged? This seems contrary to what both projects currently do. See https://github.com/iojs/io.js/releases and https://github.com/joyent/node/releases

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left that out for now because I wasn't clear on it. We can cut a release tag on every new semver-patch also

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In io.js we make pgp signed tags for every release.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, corrected in an additional commit.

@jasnell

jasnell commented Apr 14, 2015

Copy link
Copy Markdown
Member Author

@cjihrig does that look better after the additional commits?

@cjihrig

cjihrig commented Apr 14, 2015

Copy link
Copy Markdown
Contributor

LGTM. I'd still like to see if others have comments.

@mhdawson

Copy link
Copy Markdown
Member

I think the updates look good. lgtm.

@jasnell

jasnell commented Apr 14, 2015

Copy link
Copy Markdown
Member Author

Going to merge this but definitely keep the comments coming.

jasnell added a commit that referenced this pull request Apr 14, 2015
@jasnell
jasnell merged commit 67332ae into master Apr 14, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants