Skip to content

lookup: skip WPT for undici in CITGM#1107

Merged
aduh95 merged 1 commit into
mainfrom
lookup-undici-skip-wpt
Jul 9, 2026
Merged

lookup: skip WPT for undici in CITGM#1107
aduh95 merged 1 commit into
mainfrom
lookup-undici-skip-wpt

Conversation

@mcollina

Copy link
Copy Markdown
Member

Summary

Run undici's CITGM entry with an explicit script list that mirrors the default test suite while omitting test:wpt.

This keeps WPT out of Node.js release canary runs while preserving the existing CITGM=true environment for CITGM-specific skips.

Tests

  • npm test
Checklist
  • npm test passes
  • contribution guidelines followed here

Run undici's CITGM entry with explicit scripts that mirror the
default test suite but omit `test:wpt`. This avoids running WPT
during Node.js release canary runs.

Signed-off-by: Matteo Collina <hello@matteocollina.com>
@codecov-commenter

codecov-commenter commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.50%. Comparing base (1cbcf4c) to head (a0f0426).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1107      +/-   ##
==========================================
+ Coverage   96.36%   96.50%   +0.13%     
==========================================
  Files          29       29              
  Lines        2203     2203              
==========================================
+ Hits         2123     2126       +3     
+ Misses         80       77       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcollina mcollina requested review from RafaelGSS and aduh95 June 26, 2026 11:20
@mcollina

mcollina commented Jul 6, 2026

Copy link
Copy Markdown
Member Author

not sure what to do about the failing tests

@aduh95

aduh95 commented Jul 9, 2026

Copy link
Copy Markdown
Contributor
        not ok 3 - Install error reported
          ---
          diff: >
            --- expected
          
            +++ actual
          
            @@ -1,1 +1,5 @@
          
            -/\/THIS-WILL-FAIL: Not Found/
          
            +String(
          
            +  (node:3510) [DEP0205] DeprecationWarning: `module.register()` is
            deprecated. Use `module.registerHooks()` instead.
          
            +  (Use `node --trace-deprecation ...` to show where the warning was created)
          
            +  
          
            +)
          at:
            fileName: test/pnpm/test-pnpm-install.js
            lineNumber: 78
            columnNumber: 7
            typeName: Test
          stack: |
            Test.<anonymous> (test/pnpm/test-pnpm-install.js:78:7)
          source: |2
                t.notOk(context.module.flaky, 'Module failed is not flaky');
                t.equal(err && err.message, 'Install Failed');
                t.match(context.testError.toString(), expected, 'Install error reported');
            ------^
              }
            });
          ...
        
    not ok 5 - pnpm-install: failed install # time=496.744ms
      ---
      at:
        fileName: test/pnpm/test-pnpm-install.js
        lineNumber: 69
        columnNumber: 1
        isToplevel: true
      source: |
        });
      
        test('pnpm-install: failed install', async (t) => {
        ^
          t.plan(3);
          const context = npmContext('omg-bad-tree', packageManagers, sandbox);
      ...
    
    1..5
not ok 6 - test/pnpm/test-pnpm-install.js # time=1992.02ms
  ---
  stdio: inherit
  cwd: /Users/runner/work/citgm/citgm
  externalID: test/pnpm/test-pnpm-install.js
  command: /Users/runner/hostedtoolcache/node/26.3.1/arm64/bin/node
  args:
    - --import=file:///Users/runner/work/citgm/citgm/node_modules/@tapjs/typescript/dist/esm/import.mjs
    - --import=file:///Users/runner/work/citgm/citgm/node_modules/@tapjs/mock/dist/esm/import.mjs
    - --enable-source-maps
    - --import=file:///Users/runner/work/citgm/citgm/node_modules/@tapjs/processinfo/dist/esm/import.mjs
    - /Users/runner/work/citgm/citgm/test/pnpm/test-pnpm-install.js
  jobId: 0
  exitCode: 1
  signal: null
  ...

@aduh95

aduh95 commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Looks like those errors did not show up in https://ci.nodejs.org/job/citgm-smoker/3739/#showFailuresLink, it might have been fixed upstream

@aduh95 aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@aduh95 aduh95 merged commit 7712824 into main Jul 9, 2026
36 of 42 checks passed
@aduh95 aduh95 deleted the lookup-undici-skip-wpt branch July 9, 2026 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants