Repository navigation
jenkins: release 10.x on centos7-ppcle - #1919
Merged
sam-github merged 1 commit intoSep 19, 2019
Merged
Conversation
ci is passing tests with 10.x on centos7-ppcle, see #1918, so start building releases on it.
rvagg
approved these changes
Sep 19, 2019
rvagg
left a comment
rvagg
left a comment
Member
There was a problem hiding this comment.
I think that's right... "exclude" really makes this hard doesn't it? I wonder how it would look if we flipped it all to "include"
richardlau
approved these changes
Sep 19, 2019
BethGriggs
approved these changes
Sep 19, 2019
Contributor
Author
|
Ok, @BethGriggs any ideas how I should test this? Perhaps 10.x nightlies tonight will be built on the new release machines, so I can run them? Or, @mhdawson the napi failures you found might go away with this change, since they are using the nightlies on ubuntu1404 machines. |
Contributor
Author
|
I think switching to include might make things look weird, but from a different angle. And I'm getting used to exclude. Stockholm syndrome? |
Member
|
Unless there is something new in the nightlies we won't get one. I'll kick one off. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ci is passing tests with 10.x on centos7-ppcle, see #1918, so start
building releases on it.
@nodejs/lts