Skip to content

CI: make test-ci-js got broke and we didn't notice #910

Description

@refack

In nodejs/node@5be4dfa#diff-b67911656ef5d18c4ae36cb6741b7965R362
the make target test-ci-js lost $(CI_JS_SUITES) so it only tested async-hooks and known_issues (70 tests).

AFAICT it's only used by node-test-binary-arm, but that made me think - can we merge all the TAP reports and put upstream (similar to citgm-smoker)?

Fix PR: nodejs/node#16132

results from one subset
+ make test-ci-js
# Clean up any leftover processes but don't error if found.
ps awwx | grep Release/node | grep -v grep | cat
python tools/test.py -j 1 -p tap --logfile test.tap \
	--mode=release --flaky-tests=dontcare \
	--run=1,7 async-hooks known_issues
TAP version 13
1..10
ok 1 async-hooks/test-connection.ssl
  ---
  duration_ms: 2.527
  ...
ok 2 async-hooks/test-embedder.api.async-resource.improper-order
  ---
  duration_ms: 1.525
  ...
ok 3 async-hooks/test-fseventwrap
  ---
  duration_ms: 0.823
  ...
ok 4 async-hooks/test-graph.intervals
  ---
  duration_ms: 0.924
  ...
ok 5 async-hooks/test-graph.timeouts
  ---
  duration_ms: 0.823
  ...
ok 6 async-hooks/test-pipeconnectwrap
  ---
  duration_ms: 0.923
  ...
ok 7 async-hooks/test-signalwrap
  ---
  duration_ms: 1.24
  ...
ok 8 async-hooks/test-ttywrap.writestream # skip no valid writable TTY available
  ---
  duration_ms: 0.923
  ...
ok 9 known_issues/test-http-path-contains-unicode
  ---
  duration_ms: 1.24
  ...
ok 10 known_issues/test-vm-attributes-property-not-on-sandbox
  ---
  duration_ms: 0.823
  ...
# Clean up any leftover processes, error if found.
ps awwx | grep Release/node | grep -v grep | cat
[node-test-binary-arm] $ /bin/sh -xe /tmp/hudson5021250183769314254.sh
+ set +x
Tue 10 Oct 16:27:15 UTC 2017
+ pgrep node
+ true
TAP Reports Processing: START
Looking for TAP results report in workspace using pattern: *.tap
Saving reports...
Processing '/var/lib/jenkins/jobs/node-test-binary-arm/configurations/axis-RUN_SUBSET/1/axis-label/pi3-raspbian-jessie/builds/10769/tap-master-files/test.tap'
Parsing TAP test result [/var/lib/jenkins/jobs/node-test-binary-arm/configurations/axis-RUN_SUBSET/1/axis-label/pi3-raspbian-jessie/builds/10769/tap-master-files/test.tap].
TAP Reports Processing: FINISH
Checking ^not ok
Notifying upstream projects of job completion
Finished: SUCCESS

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions