Skip to content
This repository was archived by the owner on Mar 25, 2018. It is now read-only.

Dockerfiles for iojs and libuv on debian stable and testing - #5

Merged
rvagg merged 3 commits into
nodejs:masterfrom
ghostbar:feature/debian-containers
Dec 8, 2014
Merged

rvagg merged 3 commits into
nodejs:masterfrom
ghostbar:feature/debian-containers

Conversation

@ghostbar

@ghostbar ghostbar commented Dec 6, 2014

Copy link
Copy Markdown
Contributor

I made the user iojs and the /opt/node is /opt/iojs.

Let me know if this is OK or I should change it.

@ghostbar

ghostbar commented Dec 6, 2014

Copy link
Copy Markdown
Contributor Author

This is not yet ready, although @rvagg I would like some feedback on how you're planning to have the data on the /opt/{libuv,iojs} directories. You want the output on the host system?

@rvagg

rvagg commented Dec 6, 2014

Copy link
Copy Markdown
Member

Have a look at the build output for how these are run: https://jenkins-node-forward.nodesource.com/job/iojs+any-pr+containers/nodes=node-forward-digitalocean-containers-ubuntu+trusty/lastBuild/consoleFull

There is a git checkout and then it launches docker as part of the normal flow, capturing the output and exit code as if it's a normal test executable.

@rvagg

rvagg commented Dec 6, 2014

Copy link
Copy Markdown
Member

I'll change them all to use "iojs" so your change is fine.

Comment thread debian/iojs-stable/Dockerfile Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny nit: all lowercase: "io.js"

rvagg added a commit that referenced this pull request Dec 8, 2014
Dockerfiles for iojs and libuv on debian stable and testing
@rvagg
rvagg merged commit 880921e into nodejs:master Dec 8, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants