Skip to content

Request token for nodejs/userland-migrations #1055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
avivkeller wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −0
Open

Request token for nodejs/userland-migrations #1055

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions request-an-access-token.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ Repo | Secret name | Expirati
[`nodejs-private/security-release`][] | `SECURITY_WG_GITHUB_TOKEN` | 2027-01-30 | <https://github.com/nodejs/admin/pull/950> |
[`nodejs/require-in-the-middle`][] | `RELEASE_PLEASE_GITHUB_TOKEN` | 2027-01-30 | <https://github.com/nodejs/admin/pull/951> |
[`nodejs/orchestrion-js`][] | `RELEASE_PLEASE_GITHUB_TOKEN` | 2026-11-08 | <https://github.com/nodejs/admin/pull/1023> |
[`nodejs/userland-migrations`][] | `LEARN_REPO_TOKEN` | | <https://github.com/nodejs/admin/pull/1055> |
Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The registry requires an expiration date (and notes tokens should be renewed within 1 year), but this new entry leaves the expiration date blank. Please set a concrete expiration date for this token so audits/renewals are trackable.

Suggested change
[`nodejs/userland-migrations`][] | `LEARN_REPO_TOKEN` | | <https://github.com/nodejs/admin/pull/1055> |
[`nodejs/userland-migrations`][] | `LEARN_REPO_TOKEN` | 2027-04-06 | <https://github.com/nodejs/admin/pull/1055> |

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description says the token needs contents: write and pull-requests: write on nodejs/learn, but the registry entry adds nodejs/userland-migrations as the repo. If the token is actually scoped to nodejs/learn, the registry should list nodejs/learn (or otherwise clarify in the registry/PR description which repo the token is scoped to vs where the secret is stored).

Copilot uses AI. Check for mistakes.

[`@nodejs-github-bot`]: https://github.com/nodejs-github-bot
[`nodejs-private/security-release`]: https://github.com/nodejs-private/security-release
Expand All @@ -63,3 +64,4 @@ Repo | Secret name | Expirati
[`nodejs/require-in-the-middle`]: https://github.com/nodejs/require-in-the-middle
[`nodejs/wasm-builder`]: https://github.com/nodejs/wasm-builder
[`nodejs/doc-kit`]: https://github.com/nodejs/doc-kit
[`nodejs/userland-migrations`]: https://github.com/nodejs/userland-migrations
Loading