Skip to content

napi: Buffer data argument should be void* instead of char* - #145

Merged
boingoing merged 1 commit into
nodejs:api-prototype-8.xfrom
boingoing:change_buffer_data_to_void_type
Mar 15, 2017
Merged

boingoing merged 1 commit into
nodejs:api-prototype-8.xfrom
boingoing:change_buffer_data_to_void_type

Conversation

@boingoing

Copy link
Copy Markdown

Seems the fact that these API take char* for the data parameter was more of a historical oversight in the design of node::Buffer than anything else. We should take the opportunity to clean up this rough edge with the new API contract.

Fixes #135

Seems the fact that these API take ```char*``` for the data parameter was more of a historical oversight in the design of ```node::Buffer``` than anything else. We should take the opportunity to clean up this rough edge with the new API contract.
mhdawson

This comment was marked as off-topic.

@mhdawson

Copy link
Copy Markdown
Member

@boingoing
boingoing merged commit e63b9ea into nodejs:api-prototype-8.x Mar 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants