[BUG] freeSocketTimeout is used when an active request is being made #106

Activity

1. making3

   changed the title [-]freeSocketTimeout is used when an active request is being made[/-] [+][BUG] freeSocketTimeout is used when an active request is being made[/+] on Aug 26, 2022
2. making3 commented on Aug 26, 2022

   

   making3

   on Aug 26, 2022

   Author

   More actions

   To pull in some of the debug logs and to hopefully make sense of them:

     agentkeepalive sock[0#0.0.0.0:8089:] create, timeout 60000ms +0ms
   Responding with redirect to /fake-path
     agentkeepalive sock[0#0.0.0.0:8089:](requests: 1, finished: 1) free +11ms
     agentkeepalive sock[0#0.0.0.0:8089:](requests: 2, finished: 1) will be reuse on agent free event +0ms
   Responding normally
     agentkeepalive sock[0#0.0.0.0:8089:](requests: 2, finished: 1) timeout after 800ms, listeners 4, defaultTimeoutListenerCount 3, hasHttpRequest true, HttpRequest timeoutListenerCount 0 +805ms
     agentkeepalive timeout listeners: onTimeout, onTimeout, emitRequestTimeout, responseOnTimeout +1ms
     agentkeepalive sock[0#0.0.0.0:8089:] destroy with timeout error +1ms
     agentkeepalive sock[0#0.0.0.0:8089:](requests: 2, finished: 1) error: Error: Socket timeout
   

   From my understanding, the following sequence of events happen:

   1. A socket is created (sock[0#0.0.0.0:8089:0]).
   2. The HTTP Server responds.
   3. The 'free' event is emitted (since this is undocumented, I have no idea what condition that causes this to get emitted).
   4. Because something else is still requesting information (a redirect in this case), a new request is added to this socket, however, the timeout looks to be set to the freeAgentTimeout.
   5. Because my server (or client) doesn't finish within 800ms, ERR_SOCKET_TIMEOUT is thrown, as the timeout is actually 800ms and the socket tried to close with an active request.

   While I don't have a clear picture if our server is slow or client is slow, the 5 minute default fetch-timeout from NPM should ideally still be used, I believe.