Added Support for Compression#1017
Merged
tunnckoCore merged 3 commits intonode-formidable:masterfrom Feb 18, 2026
Merged
Conversation
For: Gzip, Deflate, Brotli and Compress
Member
|
@Coding4ever123 thanks for that. I'll keep it in mind. |
Contributor
Author
|
Any update? |
Member
|
@Coding4ever123 not yet. But i believe a temporary workaround is through plugins? 🤔 |
Member
|
@AdrianDoesCoding merged. not sure when it could be included in a release though. probably soon. |
guimard
added a commit
to guimard/formidable
that referenced
this pull request
Apr 17, 2026
Since parse() was made async in 3.3.2, it awaits writeHeaders() before attaching its data listener (req.pipe after node-formidable#1017). If a caller has attached a 'data' listener on the request before calling form.parse() (e.g. for content-length accounting), the request stream is already in flowing mode. Chunks that arrive during the await are emitted and lost before Formidable pipes the stream, causing the first part(s) of a multipart body to be silently dropped. Pause the request at the top of parse() so that chunks are buffered internally until the parser is ready. req.pipe(pipe) resumes the stream, so no explicit resume is needed. Fixes the regression exposed by downstream node-form-data tests (test-ranged-filestream.js), where the caller adds a req.on('data') listener for content-length accounting before form.parse(req).
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For:
Gzip, Deflate, Brotli and Compress