Add import background job#98
Merged
Merged
Conversation
2 tasks
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal
force-pushed
the
enh/add-import-job
branch
from
0cf4bf9 to
1314791
Compare
PVince81
reviewed
Apr 13, 2022
| /** @var int */ | ||
| protected $status; | ||
|
|
||
| public function __construct() { |
Member
There was a problem hiding this comment.
maybe we can just reuse the same table and add a flag to say whether it's an import or export ?
Member
Author
There was a problem hiding this comment.
The oc_user_import_jobs table adds the target_user and path columns which oc_user_export_jobs doesn't have, so unless this massively impacts performance negatively let's keep it separate for now and add another migration later, if it's beneficial, to combine them into a oc_user_migration_jobs table and drop the other two
PVince81
approved these changes
Apr 13, 2022
Member
PVince81
left a comment
PVince81
left a comment
There was a problem hiding this comment.
Code looks fine 👍
We can discuss separately if we should merge the import and export tables
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the import background job required for the API and to be started on the UI