#8332: Tag files when AI generated content gets added#8446
Open
#8332: Tag files when AI generated content gets added#8446
Conversation
Signed-off-by: samin-z <samin.zavarkesh@gmail.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
github-project-automation
bot
moved this to 🧭 Planning evaluation (don't pick)
in 📝 Productivity team
Signed-off-by: samin-z <samin.zavarkesh@gmail.com>
samin-z
requested review from
max-nextcloud,
mejo- and
silverkszlo
as code owners
CarlSchwan
reviewed
Apr 10, 2026
Comment on lines
+19
to
+22
| /** @var IRequest|MockObject */ | ||
| private $request; | ||
| /** @var AiTagService|MockObject */ | ||
| private $aiTagService; |
Member
There was a problem hiding this comment.
Suggested change
| /** @var IRequest|MockObject */ | |
| private $request; | |
| /** @var AiTagService|MockObject */ | |
| private $aiTagService; | |
| private IRequest&MockObject $request; | |
| private AiTagService&MockObject $aiTagService; |
Signed-off-by: samin-z <samin.zavarkesh@gmail.com>
blizzz
reviewed
Apr 14, 2026
Member
blizzz
left a comment
blizzz
left a comment
There was a problem hiding this comment.
Nitpicking, but otherwise looks good, did not test.
| * | ||
| * @return void | ||
| * | ||
| * @throws \Exception |
| public function tagFileAsAiGenerated(int $fileId): void { | ||
| try { | ||
| $this->systemTagObjectMapper->assignGeneratedByAITag((string)$fileId, 'files'); | ||
| } catch (\Exception $e) { |
Member
There was a problem hiding this comment.
There is no signature in the called function that says it throws an Excpetion, or is there? Would then not do it, and avoid catching an Exception that should not be caught here.
Author
There was a problem hiding this comment.
you're right, I added @throws thinking the underlying call (assignTags) might throw at runtime but since I'm already catching everything in the try/catch it never reaches the caller anyway. i'll rwmove the annotation.
Signed-off-by: samin-z <samin.zavarkesh@gmail.com>
blizzz
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
🖼️ Screenshots
🚧 TODO
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)