fix(appconfig): make type-conflict error self-explanatory

[ChristophWurst]

• Resolves: #

Summary

When a stored app config value has a different type than the one an app requests via a typed getter, getTypedValue() threw the opaque message 'conflict with value type from database' with no app, key or type information. Admins had no way to tell which key was affected or why. Example: nextcloud/mail#13537.

Name the config key and both types (using convertTypeToString(), like the setTypedValue() throw already does) in the log line and exception message.

Before:

Technical details

    Remote Address: 127.0.0.1
    Request ID: WW1YSUk264BSTx35WFtG
    Type: OCP\Exceptions\AppConfigTypeConflictException
    Code: 0
    Message: conflict with value type from database
    File: /nextcloud/lib/private/AppConfig.php
    Line: 542

After:

Technical details

    Remote Address: 127.0.0.1
    Request ID: hJHOpVUa9PD4YKLrkV9m
    Type: OCP\Exceptions\AppConfigTypeConflictException
    Code: 0
    Message: Config value mail/importance_classification_default is stored as string but was requested as boolean
    File: /nextcloud/lib/private/AppConfig.php
    Line: 549

TODO

• Do

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)
• Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
• Milestone added for target branch/version (ex: 32.x for stable32)

AI (if applicable)

• The content of this PR was partly or fully generated using AI

[ChristophWurst]

/backport to stable34

[ChristophWurst]

/backport to stable33

[ChristophWurst]

/backport to stable32

[provokateurin]

Should each of them have it's own try-catch block?

[ChristophWurst]

Used the same snippet as

server/lib/private/AppConfig.php

Lines 911 to 924 in af54c76

	/**
	* we only accept a different type from the one stored in database
	* if the one stored in database is not-defined (VALUE_MIXED)
	*/
	if (!$this->isTyped(self::VALUE_MIXED, $currType)
	&& ($type | self::VALUE_SENSITIVE) !== ($currType | self::VALUE_SENSITIVE)) {
	try {
	$currType = $this->convertTypeToString($currType);
	$type = $this->convertTypeToString($type);
	} catch (AppConfigIncorrectTypeException) {
	// can be ignored, this was just needed for a better exception message.
	}
	throw new AppConfigTypeConflictException('conflict between new type (' . $type . ') and old type (' . $currType . ')');
	}

so not sure

[ChristophWurst]

/backport to stable35