Skip to content

feat(teams): add ITeamFileResourceProvider for cross-provider file lookups - #63444

Draft
pringelmann wants to merge 1 commit into
masterfrom
feat/teams-file-resource-provider
Draft

feat(teams): add ITeamFileResourceProvider for cross-provider file lookups#63444
pringelmann wants to merge 1 commit into
masterfrom
feat/teams-file-resource-provider

Conversation

@pringelmann

@pringelmann pringelmann commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Summary

The teams lookup asks a single provider, picked by the providerId in the route. For a file that is always files, which circles owns and answers from oc_share. A team folder is mounted rather than shared, so there is no share row, the answer comes back empty, and the sidebar card hides itself.

This adds ITeamFileResolver, one interface with one method. When the lookup was addressed by file id, TeamManager also asks every provider implementing it and merges the result. groupfolders does the answering in nextcloud/groupfolders#5035.

Tested on a team space, a folder shared with a team, files two levels deep, and a file belonging to no team. A Deck board on the same team lands in the same card:

image

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI (tests)

Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
@pringelmann
pringelmann force-pushed the feat/teams-file-resource-provider branch from b4cf1d3 to be46509 Compare August 21, 2026 09:27
@pringelmann pringelmann self-assigned this Aug 21, 2026
@pringelmann pringelmann added bug feature: sharing feature: file sidebar Related to the file sidebar component feature: teams Related to Teams or circles team: IDP Code maintained by 🪪 IDP team labels Aug 21, 2026
@pringelmann pringelmann added this to the Nextcloud 35 milestone Aug 21, 2026
@pringelmann pringelmann added the 3. to review Waiting for reviews label Aug 21, 2026
@pringelmann
pringelmann marked this pull request as ready for review August 21, 2026 09:32
@pringelmann
pringelmann requested a review from a team as a code owner August 21, 2026 09:32
@pringelmann
pringelmann requested review from Altahrim, artonge, come-nc, provokateurin and salmart-dev and removed request for a team August 21, 2026 09:32
@skjnldsv skjnldsv mentioned this pull request Aug 25, 2026
@pringelmann pringelmann added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Aug 27, 2026
@pringelmann
pringelmann marked this pull request as draft August 27, 2026 15:33
@pringelmann

Copy link
Copy Markdown
Contributor Author

Need to rethink my approach - will open again soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing Work in progress bug feature: file sidebar Related to the file sidebar component feature: sharing feature: teams Related to Teams or circles team: IDP Code maintained by 🪪 IDP team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement a team resource provider

1 participant