test(s3): fix flaky EOF check and remove PHP 8.5 skip#61275
Open
joshtrichards wants to merge 2 commits into
Open
test(s3): fix flaky EOF check and remove PHP 8.5 skip#61275joshtrichards wants to merge 2 commits into
joshtrichards wants to merge 2 commits into
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
S3Test::testFileSizes()so it no longer relies on an invalid EOF behavior assumption and remove the temporary PHP 8.5 CI skip.Changes
feof()check afterfseek()with a read-at-EOF assertionassertSame()checks for byte comparisonsWhy
readObject()returns a seekable HTTP-backed stream, andfeof()is not a reliable thing to assert immediately after seeking to the end of that stream.Depending on buffering and wrapper behavior, EOF may only be established after a read attempt. Verifying that a read at EOF returns no bytes better matches the behavior this test intends to validate and avoids CI flakiness. The original exclusion by PHP version was for PHP 8.3 (#47388), but recently was changed to 8.5 (#61158). Presumably it's no longer needed (if evidence suggests otherwise going forward we should figure out why / fix the test).
Checklist
3. to review, feature component)stable32)AI (if applicable)