perf: only load possible results in UserMountCache::getMountForPath#59649
Open
icewind1991 wants to merge 2 commits intomasterfrom
Open
perf: only load possible results in UserMountCache::getMountForPath#59649icewind1991 wants to merge 2 commits intomasterfrom
icewind1991 wants to merge 2 commits intomasterfrom
Conversation
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
requested review from
Altahrim,
leftybournes,
nfebe and
salmart-dev
and removed request for
a team
Member
Author
|
/backport to stable33 |
Member
Author
|
/backport to stable32 |
salmart-dev
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #57760 for easier reviews.
Instead of always loading all mounts for the user and then finding the relevant one for a path. We first collect the possible paths the mountpoint can be at (the path and all it's parents), and then only load the mounts for those paths.