Skip to content

fix(files): add missing table header for actions column#59425

Merged
susnux merged 2 commits intomasterfrom
fix/files-table-header
Apr 16, 2026
Merged

fix(files): add missing table header for actions column#59425
susnux merged 2 commits intomasterfrom
fix/files-table-header

Conversation

@susnux
Copy link
Copy Markdown
Contributor

@susnux susnux commented Apr 3, 2026

Every column needs an header with some label for accessibility, so screen reader know which column they are in currently. This adds the missing header (but hides it visually so only for SR).

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@susnux susnux requested review from a team and skjnldsv as code owners April 3, 2026 15:07
@susnux susnux requested review from cristianscheid, nfebe, salmart-dev and sorbaugh and removed request for a team and sorbaugh April 3, 2026 15:07
@susnux susnux added this to the Nextcloud 34 milestone Apr 3, 2026
@susnux
Copy link
Copy Markdown
Contributor Author

susnux commented Apr 3, 2026

/backport to stable32

@susnux
Copy link
Copy Markdown
Contributor Author

susnux commented Apr 3, 2026

/backport to stable33

Copy link
Copy Markdown
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

- resolves #59333

Every column needs an header with some label for accessibility,
so screen reader know which column they are in currently.
This adds the missing header (but hides it visually so only for SR).

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
Copy link
Copy Markdown
Contributor Author

susnux commented Apr 16, 2026

/compile

@susnux susnux force-pushed the fix/files-table-header branch from d45ed33 to ab1c426 Compare April 16, 2026 13:22
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux susnux merged commit 288964b into master Apr 16, 2026
132 of 134 checks passed
@susnux susnux deleted the fix/files-table-header branch April 16, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Accessibility: No header cells assigned to data cells in tables

6 participants