fix: duplicate dashboard widget#59335
Conversation
susnux
left a comment
There was a problem hiding this comment.
Thank you for your pull request!
I have just one comment:
|
/backport to stable33 |
|
/backport to stable32 |
|
@leftybournes , @Altahrim , @CarlSchwan , @provokateurin |
Signed-off-by: mykh-hailo <kristianderonta0205@gmail.com>
Signed-off-by: mykh-hailo <kristianderonta0205@gmail.com>
cf0e579 to
708fa13
Compare
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Summary
This PR fixes a dashboard layout edge case where duplicate widget IDs can be sent to the layout update endpoint.
Even though the UI only allows selecting a widget once, crafted requests could still submit duplicates (e.g.
layout[]=files&layout[]=files). This caused duplicated entries to be persisted.Checklist
3. to review, feature component)stable32)AI (if applicable)