Skip to content

fix: duplicate dashboard widget#59335

Merged
susnux merged 2 commits intonextcloud:masterfrom
mykh-hailo:fix/duplicate-dashboard-widget
Apr 2, 2026
Merged

fix: duplicate dashboard widget#59335
susnux merged 2 commits intonextcloud:masterfrom
mykh-hailo:fix/duplicate-dashboard-widget

Conversation

@mykh-hailo
Copy link
Copy Markdown
Contributor

@mykh-hailo mykh-hailo commented Mar 31, 2026

Summary

This PR fixes a dashboard layout edge case where duplicate widget IDs can be sent to the layout update endpoint.
Even though the UI only allows selecting a widget once, crafted requests could still submit duplicates (e.g. layout[]=files&layout[]=files). This caused duplicated entries to be persisted.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@mykh-hailo mykh-hailo requested a review from a team as a code owner March 31, 2026 09:43
@mykh-hailo mykh-hailo requested review from Altahrim, CarlSchwan, leftybournes and provokateurin and removed request for a team March 31, 2026 09:43
Copy link
Copy Markdown
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!
I have just one comment:

Comment thread apps/dashboard/lib/Service/DashboardService.php Outdated
@susnux susnux added this to the Nextcloud 34 milestone Mar 31, 2026
@susnux
Copy link
Copy Markdown
Contributor

susnux commented Mar 31, 2026

/backport to stable33

@susnux
Copy link
Copy Markdown
Contributor

susnux commented Mar 31, 2026

/backport to stable32

@susnux susnux self-assigned this Mar 31, 2026
@mykh-hailo
Copy link
Copy Markdown
Contributor Author

@leftybournes , @Altahrim , @CarlSchwan , @provokateurin
I'd appreciate it if you review this PR at your convenience.

Signed-off-by: mykh-hailo <kristianderonta0205@gmail.com>
Signed-off-by: mykh-hailo <kristianderonta0205@gmail.com>
@susnux susnux force-pushed the fix/duplicate-dashboard-widget branch from cf0e579 to 708fa13 Compare April 2, 2026 18:20
@susnux susnux merged commit 521e618 into nextcloud:master Apr 2, 2026
231 of 245 checks passed
@welcome
Copy link
Copy Markdown

welcome Bot commented Apr 2, 2026

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@github-actions
Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dashboard widget can be added multiple times

4 participants