Skip to content

Cleanup OC_User and OS_JSON#58751

Open
CarlSchwan wants to merge 2 commits intomasterfrom
carl/oc_user
Open

Cleanup OC_User and OS_JSON#58751
CarlSchwan wants to merge 2 commits intomasterfrom
carl/oc_user

Conversation

@CarlSchwan
Copy link
Copy Markdown
Member

  • Resolves: #

Summary

TODO

  • ...

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Comment thread apps/dav/tests/unit/Connector/Sabre/PublicAuthTest.php Outdated
Comment thread apps/dav/tests/unit/Connector/LegacyPublicAuthTest.php Outdated
Comment thread apps/files_trashbin/lib/Trashbin.php Outdated
Comment thread apps/files_trashbin/lib/Trashbin.php
@CarlSchwan CarlSchwan force-pushed the carl/oc_user branch 2 times, most recently from 8bc7f67 to d89fdb4 Compare March 10, 2026 17:26
@CarlSchwan CarlSchwan marked this pull request as ready for review March 10, 2026 17:31
@CarlSchwan CarlSchwan requested a review from a team as a code owner March 10, 2026 17:31
@CarlSchwan CarlSchwan requested review from ArtificialOwl, artonge, salmart-dev and sorbaugh and removed request for a team March 10, 2026 17:31
Comment thread tests/lib/TestCase.php Outdated
Comment thread lib/private/legacy/OC_User.php Outdated
Comment thread lib/private/legacy/OC_User.php Outdated
* @suppress PhanDeprecatedFunction
* @deprecated 34.0.0 This is internal, not to be used by apps
*/
public static function useBackend($backend = 'database') {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure whether we can already remove useBackend and clearBackends. Does it respect our deprecation policy?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's in private and last usage I found was in deck nextcloud/deck#7848

And deprecated OC_User::setPassword

Signed-off-by: Carl Schwan <carlschwan@kde.org>
And replace most usages in Server with the newer APIs

Signed-off-by: Carl Schwan <carlschwan@kde.org>
@artonge artonge added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 php Pull requests that update Php code pending documentation This pull request needs an associated documentation update labels Apr 16, 2026

//trigger creation of user home and /files folder
\OC::$server->getUserFolder($uid);
if (!$user->isEnabled()) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$user may be null here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews pending documentation This pull request needs an associated documentation update php Pull requests that update Php code technical debt 🧱 🤔🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants