Skip to content

[stable33] fix: show configuration options for external storage backends#58696

Merged
AndyScherzinger merged 1 commit intostable33from
backport/58205/stable33
Apr 20, 2026
Merged

[stable33] fix: show configuration options for external storage backends#58696
AndyScherzinger merged 1 commit intostable33from
backport/58205/stable33

Conversation

@kesselb
Copy link
Copy Markdown
Contributor

@kesselb kesselb commented Mar 3, 2026

Manual backport of #58205

Summary

The occ files_external_backends command is supposed to list available backends along with their configuration options.

For the SMB backend, only the timeout option is currently shown, while options like host, share, root, and domain are missing. This makes configuring external storage via occ complicated.

Since the timeout option is marked as hidden but still shown, while the other options are not, the logic needs to be inverted so that all relevant configuration options are displayed correctly.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

The occ files_external_backends command is supposed to list available backends along with their configuration options.

For the SMB backend, only the timeout option is currently shown, while options like host, share, root, and domain are missing. This makes configuring external storage via occ complicated.

Since the timeout option is marked as hidden but still shown, while the other options are not, the logic needs to be inverted so that all relevant configuration options are displayed correctly.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb requested review from blizzz and provokateurin March 3, 2026 16:14
@kesselb kesselb requested a review from a team as a code owner March 3, 2026 16:14
@kesselb kesselb self-assigned this Mar 3, 2026
@kesselb kesselb removed the request for review from a team March 3, 2026 16:14
@kesselb kesselb added the bug label Mar 3, 2026
@kesselb kesselb added the 3. to review Waiting for reviews label Mar 3, 2026
@github-actions github-actions Bot changed the title fix: show configuration options for external storage backends [stable33] fix: show configuration options for external storage backends Mar 3, 2026
@kesselb kesselb added this to the Nextcloud 33.0.3 milestone Apr 2, 2026
Copy link
Copy Markdown
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@AndyScherzinger AndyScherzinger merged commit 465fa59 into stable33 Apr 20, 2026
197 of 201 checks passed
@AndyScherzinger AndyScherzinger deleted the backport/58205/stable33 branch April 20, 2026 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants