Skip to content

Add comments reactions#30379

Merged
nickvergessen merged 22 commits intomasterfrom
feature/add-comments-reactions
Jan 21, 2022
Merged

Add comments reactions#30379
nickvergessen merged 22 commits intomasterfrom
feature/add-comments-reactions

Conversation

@vitormattos
Copy link
Copy Markdown

@vitormattos vitormattos commented Dec 22, 2021

Changes on app comments to resolve nextcloud/spreed#1920

Depends of #30393 and #30378

@vitormattos vitormattos added enhancement 2. developing Work in progress feature: comments php Pull requests that update Php code labels Dec 22, 2021
@vitormattos vitormattos added this to the Nextcloud 24 milestone Dec 22, 2021
@vitormattos vitormattos marked this pull request as draft December 22, 2021 18:12
@vitormattos
Copy link
Copy Markdown
Author

static tests fixed on #30370

@vitormattos vitormattos force-pushed the feature/add-comments-reactions branch 2 times, most recently from f1e67ef to 3c23050 Compare December 23, 2021 13:07
@vitormattos vitormattos force-pushed the feature/add-comments-reactions branch 3 times, most recently from 09b4c79 to a786259 Compare December 24, 2021 14:09
@vitormattos vitormattos marked this pull request as ready for review December 27, 2021 13:13
@vitormattos vitormattos added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 27, 2021
Comment thread lib/private/Comments/Comment.php
Comment thread lib/public/Comments/IComment.php Outdated
Comment thread lib/public/Comments/IComment.php Outdated
@vitormattos vitormattos force-pushed the feature/add-comments-reactions branch 5 times, most recently from 1c08c52 to 006a4a3 Compare December 30, 2021 23:35
Comment thread core/Migrations/Version24000Date20211222112246.php Outdated
Comment thread core/Migrations/Version24000Date20211222112246.php Outdated
Comment thread core/Migrations/Version24000Date20211222112246.php
Comment thread lib/private/Comments/Comment.php Outdated
Comment thread lib/private/Comments/Manager.php Outdated
@vitormattos vitormattos force-pushed the feature/add-comments-reactions branch 2 times, most recently from aed1b13 to 394b84b Compare January 2, 2022 19:36
Comment thread lib/public/Comments/IComment.php Outdated
@nickvergessen nickvergessen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 20, 2022
Copy link
Copy Markdown
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The asserts from testReactionAddAndDelete are not executed, and there might be a missing call to throwIfNotSupportReactions() in retrieveAllReactionsWithSpecificReaction().

The other comments are just things that would be nice to have, but not really needed.

Comment thread core/Migrations/Version24000Date20211222112246.php Outdated
Comment thread lib/private/Comments/Manager.php
Comment thread tests/lib/Comments/ManagerTest.php
Comment thread tests/lib/Comments/ManagerTest.php Outdated
Comment thread tests/lib/Comments/ManagerTest.php
vitormattos and others added 21 commits January 21, 2022 08:37
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Fix column size

Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
@vitormattos vitormattos force-pushed the feature/add-comments-reactions branch from e871521 to 7bb01b6 Compare January 21, 2022 11:45
@vitormattos vitormattos requested a review from danxuliu January 21, 2022 11:47
Signed-off-by: Vitor Mattos <vitor@php.rio>
@nickvergessen nickvergessen merged commit fccb98c into master Jan 21, 2022
@nickvergessen nickvergessen deleted the feature/add-comments-reactions branch January 21, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement feature: comments php Pull requests that update Php code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reactions to chat messages

6 participants