Conversation
| } | ||
| } | ||
|
|
||
| extension List where Element == tableMetadataTag { |
There was a problem hiding this comment.
we only use tableMetadataTag as a Realm model in DB. Anywhere else we use NKTag. This way we separate DB Models with plain models, and avoid using things like detachedCopy as tableMetadata does.
| if oldSchemaVersion < 408 { | ||
| migration.enumerateObjects(ofType: tableMetadata.className()) { oldObject, newObject in | ||
| guard let oldObject, let newObject else { | ||
| return | ||
| } | ||
|
|
||
| let oldTags: [String] | ||
| if let oldList = oldObject["tags"] as? List<String> { | ||
| oldTags = Array(oldList) | ||
| } else if let oldArray = oldObject["tags"] as? [String] { | ||
| oldTags = oldArray | ||
| } else { | ||
| oldTags = [] | ||
| } | ||
|
|
||
| let migratedTags = oldTags.map { tagName in | ||
| migration.create( | ||
| tableMetadataTag.className(), | ||
| value: [ | ||
| "id": "", | ||
| "name": tagName, | ||
| "color": "" | ||
| ] | ||
| ) | ||
| } | ||
| newObject["tags"] = migratedTags | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
@marinofaggiana Please check if migration is correct. For me it worked fine.
…anage Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
|
Can you check with web (or ask designers), but I think there should not be shown more than 3-5 tags, but then better show "+"? |
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Not sure what you mean. File details shows all tags on android as well: 
Only 2 tags are shown on the file list, on both iOS and Android: 
|
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
3 participants
Implements: #4040
Prerequisite: nextcloud/NextcloudKit#214
Screenshots (before and after):
Screenshots (new screen):
