fix: always use the internal back button#1690
Merged
Conversation
Contributor
susnux
commented
Sep 10, 2025
susnux
commented
- resolves the back button is missing from modal in desktop mode #1674
Contributor
Author
|
/backport to stable32 |
Collaborator
|
/backport to stable32 |
szaimen
approved these changes
Sep 11, 2025
Collaborator
szaimen
left a comment
szaimen
left a comment
There was a problem hiding this comment.
Tested and works!
But didnt review the code
The downside of this approach is that the arrow keys do not work anymore. However I'd say this is fine. WDYT @nextcloud/designers?
Member
|
I'm fine with that, thanks @susnux :) |
marcoambrosini
approved these changes
Sep 12, 2025
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/show-back-button
branch
from
1acfdd5 to
b210ba5
Compare
Contributor
Author
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.